This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Enable linting for Travis #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all code has been linted (thanks **TODO**!), it is now safe to enable linting for Travis. Some cleanup actions have been performed; notably the additional `gulp` tasks for modules has been removed. Since all code has been fixed for linting, these are not useful any more.
yotamberk
approved these changes
Aug 2, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Enable linting for Travis Since all code has been linted (thanks **TODO**!), it is now safe to enable linting for Travis. Some cleanup actions have been performed; notably the additional `gulp` tasks for modules has been removed. Since all code has been fixed for linting, these are not useful any more. * Force linting error to check travis working * Travis works! Remove forced linting error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2697.
Since all code has been linted (thanks @macleodbroad-wf!), it is now safe to enable linting for Travis.
Some cleanup actions have been performed; notably the additional
gulptasks for modules hasbeen removed. Since all code has been fixed for linting, these are not useful any more.