This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Bug fix for null parent #3342
Merged
Bug fix for null parent #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danny-larsen can you reference the issue this solves? |
|
No sorry. I didn't have time to make an issue. But it is just one line and it seems like an error to me that other places in that function the parent is checked for null before accessing it. Maybe @yotamberk can help. I can see that he added it? |
|
Funny, I am @yotamberk 😆 |
yotamberk
approved these changes
Aug 9, 2017
|
Ha. I guess I was a bit quick there :) |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error on updating items in nested groups