This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Network: Fix handling of space before huge word in label text. #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies if the change appears big. There was a lot of code movement due to refactoring - which I deemed necessary in order to make sense of the code. |
yotamberk
approved these changes
Sep 22, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
…de#3470) * Refactoring of label splitting; new unit test still failing. * Label acc size calculations to separate methods. * Final fixes and cleanup
mojoaxel
added a commit
to visjs/vis-network
that referenced
this pull request
Jul 17, 2019
via @macleodbroad-wf, @wimrijnders (almende/vis#3228, almende/vis#3470, almende/vis#3486, almende/vis#3511, almende#3520) , almende#3518, almende#3575, almende#3565, almende#3603, almende#3646)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3464.
Changes
In the handling of label text, for the case of
font.multi : false, spaces are now'first class citizens', in the sense that they are treated as normal text.
Aside from solving the issue, this has the extra consequence that text width calculations
are now done correctly - previously, spaces could be ignored. This was a hidden bug.
Further:
LabelSplitter.process()Cleanup
LabelAccumulatorto separate file.LabelAccumulatorrelated to height determination to separate method(s)Label._processLabelText()to separate classLabelSplitter,the closures were only confusing.
LabeltoLabelSplitter.