network - make negative scaleFactor reverse middle arrow correctly #3474
Conversation
MightyPork
changed the title
|
Hi there! Great of you that you are willing to contribute. Can you please base the pull request on the Also, I'm not really sure how this actually reverses the arrow. I'll wait for the change to |
MightyPork
force-pushed
the
negative-arrow-scalefactor
branch
from
914a9f0 to
92b02ba
Compare
|
hmmm it got all messed up when I rebased it to develop, maybe better to start over ?? It's really just the one line. What reverses the arrow is not this change, but you using negative scale factor. But without my change, the scaling is wrong and the arrow becomes tiny when reversed. |
MightyPork
force-pushed
the
negative-arrow-scalefactor
branch
from
92b02ba to
01ea991
Compare
|
ah I think I fixed the rebase :) |
|
Yes, please make a new PR and close this one. (Even if it is one line!) Edit: Never mind, the rebase is good. I stand in awe that you managed that! |
|
no need now, did a hard reset to develop, cherry-picked my commit and force-pushed it |
|
There is still enough room there for me to stand in amazement.... |
Addendum to almende#3474. Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor.
* Network: Adjust documentation for arrows.middle.scaleFactor Addendum to #3474. Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor. * Adjusted text for review
…3488) * Network: Adjust documentation for arrows.middle.scaleFactor Addendum to almende#3474. Updated the documentation, so that users can know about flipping the middle arrow with a negative scale factor. * Adjusted text for review
This fix makes it possible to use negative
scaleFactor(eg. -1) to flip the middle arrow.The bug is with this line:
15 * scaleFactor + 3 * lineWidth- if scale factor is negative, lineWidth is applied in the wrong direction and the arrow gets smaller instead of larger.Old behavior - wrong scaling when reversed (gets worse when selected):
New behavior - scales correctly
