This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Vertical focus #3504
Merged
Vertical focus #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2017 17:10
… on an element, both for animated and non-animated calls of focus
- Turned on animation for the focus in the example - Updated function documentation
yotamberk
suggested changes
Sep 30, 2017
…nge' - Fixed the documentation on 'setRange' for the 'callback' parameter - Fixed code not meeting style guidelines
|
Updated 1 and 3. I'll get to 2 later today. |
…the example buttons do. Focus the language to be more consistent with that fact that the demo uses "setSelection"
|
I've updated the example to try to be a bit more clear about what it is demonstrating and what the buttons do. Let me know if it is more in line with what you wanted to see, and if there is a different direction you want it to go let me know. |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* - Added support for vertical scrolling while the timeline is focusing on an element, both for animated and non-animated calls of focus * - Adjusted item offset calculations to use the item parent - Turned on animation for the focus in the example - Updated function documentation * - Fixing lint issues * - Added documentation for the new 'frameCallback' parameter of 'setRange' - Fixed the documentation on 'setRange' for the 'callback' parameter - Fixed code not meeting style guidelines * - Updated the example for "setSelection" to be more clear about what the example buttons do. Focus the language to be more consistent with that fact that the demo uses "setSelection"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an attempt to satisfy #2851. Adds vertical scrolling support to the
focusmethod by hooking into the existing animation for setting the range. ThesetSelectionexample was updated with a second example showing vertical scrolling when usingfocus.