This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
[Timeline] Group height mode #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2017 17:38
|
I like it |
mbroad
approved these changes
Nov 25, 2017
mojoaxel
previously requested changes
Nov 28, 2017
docs/timeline/index.html
Outdated
| <td>heightMode</td> | ||
| <td>String</td> | ||
| <td>no</td> | ||
| <td>This field is optional. If set this overrides the global <code>groupHeightMode</code> configuration option for this group.</td> |
There was a problem hiding this comment.
Can you please all the valid option ('auto' and 'fixed') to this description.
|
@francescogc Also please update your feature branch to the current develop branch ( |
|
@mojoaxel feature branch is now up to date but I can't scroll anymore in the timeline... Is it just for me? :\ |
|
I fixed it. My mistake in a previous PR. |
yotamberk
approved these changes
Dec 9, 2017
|
Hi! |
|
If so, in which version? I couldn't find it in the latest distributable |
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
* add heightMode option * add documentation * improve documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, long time lurker here, I absolutely love this project and since I have made several changes to the library over the past few months (for a project at work) I think it's time to say thank you with a couple of PRs.
Here's the first one: it adds a global parameter called
groupHeightModethat can be overriden by a group and can have two values: 'auto' or 'fixed'. Basically it specifies how the height of a group gets calculated. If it's set to 'auto' the height is calculated based on the visibile items, like always. On the other hand, with the 'fixed' value the group keeps the same height even if there are no visible items in the timeline at that moment.I think it's a nice feature to have, hope to see it in some future version :)