This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
[Timeline] Year quarters #3717
Merged
[Timeline] Year quarters #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yotamberk
suggested changes
Jan 5, 2018
There was a problem hiding this comment.
This is really great!
I really do like it. But as you mentioned, it is a business thing.
I think a flag for quarters is needed or at least treated like the weeks. see Docs:
Note: the 'week' scale is not included in the automatic zoom levels as its scale is not a direct logical successor of 'days' nor a logical predecessor of 'months'
Quarters should be treated the same
|
@yotamberk thanks for the tip, now quarters are hidden by default. In order to show them, you need to add something like this in the timeline options: |
yotamberk
approved these changes
Jan 27, 2018
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
* timeline: add 'quarter' support * add unit test * update docs * misc * 'quarters' scale hidden by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again :) I think the title is pretty much self explanatory: this PR adds year quarters (Q1 2018, Q2 2018...) to the timeline axis.
My only concern is that not everyone is interested in having quarters displayed (since it's more of a 'business' thing) so I don't know, maybe there should be some sort of flag in the options, disabled by default, that enables quarters in the axis.
Let me know if you like it!