Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

micah/4039/hide edges on zoom #4042

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

micah/4039/hide edges on zoom #4042

wants to merge 16 commits into from

Conversation

micahstubbs
Copy link

@micahstubbs micahstubbs commented Jul 20, 2018 •
edited
Loading

This PR adds a new network interaction option to hide edges on zoom, hideEdgesOnZoom

This new option is patterned after the existing hideEdgesOnDrag option.

fix #4039

📄 steps to test

hide-edges-on-zoom-1

micahstubbs added 16 commits July 20, 2018 13:55
@micahstubbs
enhance CanvasRenderer with new redrawZoom function that does not dra…
008ee94 
…w edges during zoom
@micahstubbs
call new _requestRedrawZoom function from zoom InteractionHandler
ecc8610
@micahstubbs
use zoomStart and zoomEnd events
652f6ce
@micahstubbs
add this.zooming status to match this.dragging
2a1b696
@micahstubbs
register hideEdgesOnZoom option
2a1c145
@micahstubbs
document hideEdgesOnZoom
134109c
@micahstubbs
add type definition for hideEdgesOnZoom option
cda79f6
@micahstubbs
add hideEdgesOnZoom to setOptions function in InteractionHandler
6540674
@micahstubbs
set default option value for hideEdgesOnZoom in options config
103bee0
@micahstubbs
add redraw after zooming is complete
3410cd1
@micahstubbs
update neighborhoodHighlight example to use new hideEdgesOnZoom option
51fd38c
@micahstubbs
update babel-core to ^6.26.3 to fix build
6f377e8
@micahstubbs
mute dev logging
a41cb73
@micahstubbs
remove commented code from earlier experiment
838965b
@micahstubbs
restore newline
7cfbfd8
@micahstubbs
restore newline above comment
b8d7731
@micahstubbs micahstubbs mentioned this pull request Aug 24, 2018
Merged
@micahstubbs micahstubbs mentioned this pull request Sep 5, 2018
Open
17 tasks
@exoego
Copy link

exoego commented Jan 11, 2019

LGTM

mojoaxel
mojoaxel approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance. Very nice PR!

@mojoaxel mojoaxel mentioned this pull request Jul 26, 2019
Merged
@mojoaxel
Copy link
Member

💌 Thanks @micahstubbs for your contribution!
This pull-request has been merge into visjs/vis-network#16

@mojoaxel mojoaxel added Network visjs APPLIED this PR was merged into a repo of the visjs family labels Jul 27, 2019
@mojoaxel mojoaxel mentioned this pull request Jul 29, 2019
Open
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mojoaxel mojoaxel mojoaxel approved these changes

Assignees
No one assigned
Labels
Network visjs APPLIED this PR was merged into a repo of the visjs family
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micahstubbs @exoego @mojoaxel @yotamberk