Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: decimal data fields deserialization #483

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Fix: decimal data fields deserialization #483

merged 4 commits into from
Apr 4, 2024

Conversation

sierzput
Copy link
Contributor

@sierzput sierzput commented Feb 28, 2024 •
edited
Loading

Fix for #482

  • added unit tests showing problematic deserialization cases
  • fixed deserialization of decimal fields' scale and precision

aloneguid
aloneguid approved these changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@aloneguid aloneguid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aloneguid aloneguid added this to the 4.24.0 milestone Apr 4, 2024
@aloneguid aloneguid merged commit 2bede5f into aloneguid:master Apr 4, 2024
9 checks passed
@aloneguid aloneguid modified the milestones: 4.24.0, 4.23.5 Apr 4, 2024
@sierzput sierzput deleted the fix/decimal-data-field branch April 8, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloneguid aloneguid aloneguid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.23.5
Development

Successfully merging this pull request may close these issues.
2 participants
@sierzput @aloneguid