Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change other agent info #46

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Change other agent info #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions frontend/webapp/components/overview/sources/detected-containers/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ const DetectedContainers: React.FC<DetectedContainersProps> = ({
languages,
conditions,
}) => {
const hasError = conditions.some((condition) => condition.status === 'False');
const hasDeviceNotAddedCondition = conditions.some(
(condition) =>
condition.status === 'False' &&
condition.message.includes(
'device not added to any container due to the presence of another agent'
)
);

return (
<Container>
<KeyvalText size={18} weight={600}>
Expand All @@ -53,7 +60,13 @@ const DetectedContainers: React.FC<DetectedContainersProps> = ({
const isInstrumented =
lang.language !== 'ignore' &&
lang.language !== 'unknown' &&
!lang?.other_agent;
!lang.other_agent;

// Determine if running concurrently is possible based on language and other_agent
const canRunInParallel =
(lang.language === 'python' || lang.language === 'java') &&
!hasDeviceNotAddedCondition;

return (
<ListItem key={lang.container_name}>
<KeyvalText
Expand All @@ -63,18 +76,22 @@ const DetectedContainers: React.FC<DetectedContainersProps> = ({
{lang?.runtime_version
? `, Runtime: ${lang.runtime_version}`
: ''}
){isInstrumented && !hasError && ' - Instrumented'}
)
{isInstrumented &&
!hasDeviceNotAddedCondition &&
' - Instrumented'}
</KeyvalText>
{lang.other_agent && lang.other_agent.name && (
<KeyvalText
color={theme.colors.orange_brown}
size={12}
style={{ marginTop: 6 }}
>
{lang.language === 'python'
? `We are running concurrently with the ${lang.other_agent.name}, which is not recommended. It is advisable to disable other agents for optimal performance and compatibility.`
: `We detected another agent of ${lang.other_agent.name} that running in the container. Disable it
to instrument this source.`}
{hasDeviceNotAddedCondition
? `We cannot run alongside the ${lang.other_agent.name} agent due to configuration restrictions. `
: canRunInParallel
? `We are running concurrently with the ${lang.other_agent.name}. Ensure this is configured optimally in Kubernetes.`
: `Concurrent execution with the ${lang.other_agent.name} is not supported. Please disable one of the agents to enable proper instrumentation.`}
</KeyvalText>
)}
</ListItem>
Expand Down
Loading