Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

The rework of the Client class. #8

Merged
merged 2 commits into from
Jul 7, 2020
Merged

The rework of the Client class. #8

merged 2 commits into from
Jul 7, 2020

Conversation

aqilc
Copy link
Contributor

@aqilc aqilc commented Jul 7, 2020

The whole of the Client rework.

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Also, even if we wanted to support the close method, the current way is the worst way imaginable. Ideally, we should put the promise handling in the request method, where it's actually most useful.

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Also, Node automatically closes promises when exiting from what I know.

@aqilc aqilc changed the title Initial commit to client rework. Client rework. Jul 7, 2020
@aqilc aqilc changed the title Client rework. The rework of the Client class. Jul 7, 2020
@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Yes it does: nodejs/node#22088

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

So first thing to do now, is to remove all of the promise allocation stuff.

@117
Copy link
Contributor

117 commented Jul 7, 2020

Perhaps we make a new ‘dev’ branch for this before beginning with changes? Then we can keep pushing changes without worry.

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Oh, uhhhhh ok. I think I can switch, but I need to push my current changes first...

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Ok, here is the start of the client rework I was talking about(#5)... I do feel as if it's a bit unnecessary but I love the fact that it can group together methods and make the coding experience a bit better.

@aqilc
Copy link
Contributor Author

aqilc commented Jul 7, 2020

Ok I have to go now, see you tomorrow. Also, some way to contact you would be nice(like a Discord or email)

@117 117 changed the base branch from master to dev July 7, 2020 03:17
@117 117 merged commit c490744 into alpacahq:dev Jul 7, 2020
@117
Copy link
Contributor

117 commented Jul 7, 2020

I switched the base branch to dev and merged the PR.

@117
Copy link
Contributor

117 commented Jul 7, 2020

Ok I have to go now, see you tomorrow. Also, some way to contact you would be nice(like a Discord or email)

Discord Bubbles#9497

@aqilc
Copy link
Contributor Author

aqilc commented Jul 8, 2020

^ that started an awesome friendship

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants