-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
Also, even if we wanted to support the close method, the current way is the worst way imaginable. Ideally, we should put the promise handling in the |
Also, Node automatically closes promises when exiting from what I know. |
Yes it does: nodejs/node#22088 |
So first thing to do now, is to remove all of the promise allocation stuff. |
Perhaps we make a new ‘dev’ branch for this before beginning with changes? Then we can keep pushing changes without worry. |
Oh, uhhhhh ok. I think I can switch, but I need to push my current changes first... |
Ok, here is the start of the client rework I was talking about(#5)... I do feel as if it's a bit unnecessary but I love the fact that it can group together methods and make the coding experience a bit better. |
Ok I have to go now, see you tomorrow. Also, some way to contact you would be nice(like a Discord or email) |
I switched the base branch to |
Discord |
^ that started an awesome friendship |
The whole of the Client rework.