-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "1Sec" to queryable timeframe list #201
Conversation
@@ -2,15 +2,18 @@ | |||
# Commands to automate integration tests | |||
################################################################################ | |||
|
|||
LATEST_TAG ?= $(shell bin/dockertags alpacamarkets/marketstore | tail -1) | |||
IMAGE_NAME ?= alpacamarkets/marketstore:${LATEST_TAG} | |||
IMAGE_NAME ?= alpacahq/integrationtests.marketstore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this pull request, integration test was being run to the latest marketstore image that was already pushed.
In order to run the integration test to the code written in the pull request, we need to create docker image of marketstore every time a pull request is created
@@ -2,403 +2,403 @@ | |||
1970-01-02 21:37:57 +0000 UTC,1.05185,1.05197,139999992 | |||
1970-01-03 21:37:57 +0000 UTC,1.05185,1.05197,139999992 | |||
2016-12-30 21:37:57 +0000 UTC,1.05185,1.05197,139999992 | |||
2016-12-30 21:38:02 +0000 UTC,1.05185,1.05198,389999986 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I added the rounding to minimize the cancellation error of Nanoseconds,
( https://github.com/alpacahq/marketstore/pull/201/files#diff-c387d7519eb758ef8432f6eba7f1e99dR52 )
I needed to change the expected nanosecond values of existing test for CSV import
@umitanuki @Notargets not urgent, but we want to use 1Sec time bucket in our next project. Can you review this PR? |
I just added "1Sec" timeframe to the queryable timeframe list... and confirmed that "1Sec" timeframe is working now
↓
show command
query using pymkts