Skip to content

Commit

Permalink
Fix warnings in tree mapping
Browse files Browse the repository at this point in the history
  • Loading branch information
bernhardmgruber committed Jun 13, 2022
1 parent c2697f0 commit 2a36ee9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 3 additions & 1 deletion include/llama/mapping/tree/Mapping.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ namespace llama::mapping::tree
// TODO(bgruber): propagate use of size_type
auto const basicTreeCoord = createTreeCoord<RecordCoord<RecordCoords...>>(ai);
auto const resultTreeCoord = mergedFunctors.basicCoordToResultCoord(basicTreeCoord, basicTree);
const auto offset = internal::getTreeBlobByte(resultTree, resultTreeCoord);
const auto offset = static_cast<size_type>(internal::getTreeBlobByte(
resultTree,
resultTreeCoord)); // FIXME(bgruber): size_type should be propagated through getTreeBlobByte
return {0, offset};
}
};
Expand Down
7 changes: 5 additions & 2 deletions include/llama/mapping/tree/TreeFromDimensions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,14 @@ namespace llama::mapping::tree
LLAMA_FN_HOST_ACC_INLINE auto createTree(const ArrayIndex<V, N>& size)
{
if constexpr(Pos == N - 1)
return TreeFromRecordDim<RecordDim>{size[N - 1]};
return TreeFromRecordDim<RecordDim>{
static_cast<std::size_t>(size[N - 1])}; // FIXME(bgruber): propagate index type
else
{
Tuple inner{createTree<RecordDim, V, N, Pos + 1>(size)};
return Node<NoName, decltype(inner)>{size[Pos], inner};
return Node<NoName, decltype(inner)>{
static_cast<std::size_t>(size[Pos]),
inner}; // FIXME(bgruber): propagate index type
}
};

Expand Down

0 comments on commit 2a36ee9

Please sign in to comment.