Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot to include in tests/common.h #303

Closed
bboysnick5 opened this issue Jun 23, 2021 · 3 comments · Fixed by #304
Closed

Forgot to include in tests/common.h #303

bboysnick5 opened this issue Jun 23, 2021 · 3 comments · Fixed by #304

Comments

@bboysnick5
Copy link

Need to include #include <sstream> in tests/common.h in order for tests to compile. Otherwise line 37 std::stringstream rawSS(raw); will trigger compile time error.

bernhardmgruber added a commit to bernhardmgruber/llama that referenced this issue Jun 23, 2021
@bernhardmgruber
Copy link
Member

Thank you for spotting this! A fix is coming: #304.

I wonder though since the CI passed in the past: What compiler are you using? Maybe I should add that one! Thank you!

@bboysnick5
Copy link
Author

bboysnick5 commented Jun 23, 2021

Mac clang trunk. Also I think you should add additional dependencies for tests and examples to build, such as catch2 and openmp 5.1 in documents. Otherwise they won't compile either.

@bernhardmgruber
Copy link
Member

Mac clang trunk.

Thank you! This is related to #297 then. I'll try to get the MacOS CI sooner then.

Also I think you should add additional dependencies for tests and examples to build, such as catch2 and openmp 5.1 in documents. Otherwise they won't compile either.

We list the required dependencies in the documentation here: https://llama-doc.readthedocs.io/en/latest/pages/install.html#dependencies
We could consider adding them to the README.md as well. OpenMP 5.1 should not be required though, I think OpenMP 2.0 is enough. It might also be the case that Vc is required in the meantime for some examples. You can install those with your favorite package manager!

bernhardmgruber added a commit that referenced this issue Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants