-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama::One is insufficiently aligned #339
Labels
bug
Something isn't working
Comments
The problem is even reaching further, because in principle every View with blobs that contain the storage themselves might be insufficiently aligned. We might need to change the allocator interface to support requesting sufficiently aligned blobs. |
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Aug 31, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Aug 31, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Aug 31, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Aug 31, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Sep 2, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
to bernhardmgruber/llama
that referenced
this issue
Sep 2, 2021
This makes llama::One sufficiently aligned. Fixes: alpaka-group#339
bernhardmgruber
added a commit
that referenced
this issue
Sep 2, 2021
This makes llama::One sufficiently aligned. Fixes: #339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
llama::One
represents and maintains storage for a single record value. From the perspective of the compiler however, it is just a byte array plus the mapping and an empty array dimension coord. The latter two occupy no space and are optimized away by[[no_unique_address]]
. The compiler thus computes an alignment of 1 for allama::One
. However, on access, bytes inside allama::One
are reinterpreted as types with higher than one alignment requirements.llama::One
itself thus needs to be aligned properly depending on the contained record values.The text was updated successfully, but these errors were encountered: