Run field constructors when views are allocated #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
uninit
branch
4 times, most recently
from
381a033
to
58ef6f5
Compare
* allocView will run field constructors * add allocViewUninitialized to still have uninitialized views * add constructFields * remove isAllowedFieldType * add tree::Mapping::arrayDims() * enable many unit tests relying on fields being initialized * add tests for uninitialized views and for explicit construction
bernhardmgruber
force-pushed
the
uninit
branch
from
58ef6f5
to
26ae423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by the need to lift the restriction on field types to be trivially_constructible. It applies the following changes: