Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Null mapping #442

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Dec 14, 2021

The Null mappings maps all elements to nothing. Writing data through a reference obtained from the Null mapping discards the value. Reading through such a reference returns a default constructed object.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #442 (17127f9) into develop (0d0efbe) will decrease coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #442      +/-   ##
===========================================
- Coverage    99.22%   99.20%   -0.02%     
===========================================
  Files           56       58       +2     
  Lines         5150     5165      +15     
===========================================
+ Hits          5110     5124      +14     
- Misses          40       41       +1     
Impacted Files Coverage Δ
tests/mapping.Null.cpp 90.90% <90.90%> (ø)
include/llama/mapping/Null.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0efbe...17127f9. Read the comment docs.

@bussmann
Copy link

Next up: Identity mapping.

@bernhardmgruber
Copy link
Member Author

Next up: Identity mapping.

I am not sure what you have in mind here. How can I have an identity mapping, when domain (data space) and codomain (blob nr/offset space) are different sets?

@bernhardmgruber bernhardmgruber merged commit cd9af9b into alpaka-group:develop Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants