Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compile time bit count for BitPacked mappings #446

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Dec 16, 2021

This PR adds the ability to specify the bit count for the BitPackedIntSoA mapping and the exponent/mantissa bit counts for the BitPackedFloatSoA mappings at compile time.

It furthermore disables the clang-tidy check fuchsia-statically-constructed-objects, because it is too noisy in the unit test code.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #446 (5553f6d) into develop (b2374e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5553f6d differs from pull request most recent head 28cb7fd. Consider uploading reports for the commit 28cb7fd to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #446   +/-   ##
========================================
  Coverage    99.21%   99.22%           
========================================
  Files           59       59           
  Lines         5233     5292   +59     
========================================
+ Hits          5192     5251   +59     
  Misses          41       41           
Impacted Files Coverage Δ
tests/core.cpp 100.00% <ø> (ø)
include/llama/Core.hpp 94.87% <100.00%> (+0.27%) ⬆️
include/llama/mapping/BitPackedFloatSoA.hpp 100.00% <100.00%> (ø)
include/llama/mapping/BitPackedIntSoA.hpp 100.00% <100.00%> (ø)
tests/dump.cpp 99.01% <100.00%> (ø)
tests/mapping.BitPackedFloatSoA.cpp 100.00% <100.00%> (ø)
tests/mapping.BitPackedIntSoA.cpp 100.00% <100.00%> (ø)
tests/mapping.Bytesplit.cpp 100.00% <100.00%> (ø)
tests/mapping.Split.cpp 100.00% <100.00%> (ø)
tests/proxyrefopmixin.cpp 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2374e9...28cb7fd. Read the comment docs.

@bernhardmgruber bernhardmgruber marked this pull request as ready for review December 23, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant