Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MSVC workaround for OpenMP pragmas in lambdas #476

Merged

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Feb 28, 2022

This is supposedly fixed in Visual Studio 2022 17.2: https://developercommunity.visualstudio.com/t/OpenMP-in-lambda-expression-compile-erro/1501041

  • Verify that this is actually fixed once Visual Studio 2022 17.2 is available in the GitHub CI.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #476 (90571e9) into develop (86a359e) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 90571e9 differs from pull request most recent head e7d3423. Consider uploading reports for the commit e7d3423 to get more accurate results

@@             Coverage Diff             @@
##           develop     #476      +/-   ##
===========================================
- Coverage    99.24%   99.23%   -0.01%     
===========================================
  Files           63       59       -4     
  Lines         5439     5392      -47     
===========================================
- Hits          5398     5351      -47     
  Misses          41       41              

@bernhardmgruber
Copy link
Member Author

Just checked, the CI is still using MSVC 19.31 and not 19.32, where this should be fixed.

@bernhardmgruber
Copy link
Member Author

CI just passes the tests with MSVC 19.32.

@bernhardmgruber bernhardmgruber merged commit 6ca97e8 into alpaka-group:develop May 16, 2022
@bernhardmgruber bernhardmgruber deleted the ompinlambdafix branch May 18, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant