Drop VS2019 #539
Merged
Drop VS2019 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
dropvs2019
branch
2 times, most recently
from
e84b336
to
d3a2ee2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 98.74% 98.74% -0.01%
===========================================
Files 63 63
Lines 5888 5886 -2
===========================================
- Hits 5814 5812 -2
Misses 74 74 |
bernhardmgruber
force-pushed
the
dropvs2019
branch
from
d3a2ee2
to
2d8453b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for Visual Studio 2019 to decrease the maintenance burden. Visual Studio 2022 was released on 2021-11-08, which is enough time for it to be generally available for those who want to try LLAMA on Windows.