Fix warnings, asserts in bitpackign mappings and is_One
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #549 +/- ##
========================================
Coverage 98.79% 98.79%
========================================
Files 64 64
Lines 5868 5870 +2
========================================
+ Hits 5797 5799 +2
Misses 71 71 |
bernhardmgruber
changed the title
is_Oneis_One
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a warning, asserts that exponent bits
BitPackedFloatSoAand value bits inBitPackedIntSoAare not zero and adds the traitis_One<T>to detect whether a type is an instance ofllama::One.