Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VirtualRecord into RecordRef #551

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

bernhardmgruber
Copy link
Member

RecordRef is semantically a reference to a record, so the new name is more appropriate. The term virtual is also misleading since it has no relation to the 'virtual' keyword in C++.

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #551 (4eba3ac) into develop (379e144) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    98.81%   98.81%           
========================================
  Files           64       64           
  Lines         5979     5979           
========================================
  Hits          5908     5908           
  Misses          71       71           

RecordRef is semantically a reference to a record, so the new name is more appropriate. The term virtual is also misleading since it has no relation to the 'virtual' keyword in C++.
@bernhardmgruber bernhardmgruber marked this pull request as ready for review July 4, 2022 15:24
@bernhardmgruber bernhardmgruber merged commit b894838 into alpaka-group:develop Jul 4, 2022
@bernhardmgruber bernhardmgruber deleted the recordref branch July 4, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant