Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dumping #647

Merged
merged 4 commits into from
Dec 4, 2022
Merged

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Dec 2, 2022

This PR contains several small fixes for the dumping and textual representations of record dimension tags.

  • Escape recordTags before dumping into HTML/SVG
  • Add more tests for recordCoordTags
  • Fix names when dumping record dims with arrays
  • Check that Record is only instantiated with fields
  • Add picongpu related tests for structName and qualifiedTypeName

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #647 (eee8aec) into develop (f34257f) will decrease coverage by 0.01%.
The diff coverage is 96.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #647      +/-   ##
===========================================
- Coverage    98.78%   98.76%   -0.02%     
===========================================
  Files           73       74       +1     
  Lines         6725     6806      +81     
===========================================
+ Hits          6643     6722      +79     
- Misses          82       84       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant