Improve BitPackedIntSoA #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packed bit count is the same as the bit count of the storage integral, the code invoked UB during shifts.
bernhardmgruber
changed the title
bernhardmgruber
force-pushed
the
fix_int_pack
branch
from
d73cb3b
to
6eaf488
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #671 +/- ##
========================================
Coverage 98.75% 98.76%
========================================
Files 74 74
Lines 6808 6861 +53
========================================
+ Hits 6723 6776 +53
Misses 85 85 |
bernhardmgruber
force-pushed
the
fix_int_pack
branch
2 times, most recently
from
4b57cd2
to
5466155
Compare
bernhardmgruber
force-pushed
the
fix_int_pack
branch
from
5466155
to
80bb7c5
Compare
And adapt unit tests.
bernhardmgruber
force-pushed
the
fix_int_pack
branch
from
6bd2ec3
to
e22aaa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llama::Arrayreported by UBSan.