Various BitPackedIntSoA improvements #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bernhardmgruber
commented
Jan 13, 2023
•
bernhardmgruber
commented
- Add fastpath for single bit BitPackedIntSoA
- More tests
- Change parameter order to be more ergonomic
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #677 +/- ##
===========================================
- Coverage 98.76% 98.75% -0.01%
===========================================
Files 74 74
Lines 6881 6923 +42
===========================================
+ Hits 6796 6837 +41
- Misses 85 86 +1 |
bernhardmgruber
changed the title
bernhardmgruber
force-pushed
the
singlebit
branch
3 times, most recently
from
8129804
to
86bc8dc
Compare
* Test single bit BitPackedIntSoA * Add fastpath for single bit BitPackedIntSoA * Catch accidental loss of magnitude for signed integers * Change BitPackedIntSoA template parameter order. SignBit is used more often, so it should not be the last parameter.
bernhardmgruber
force-pushed
the
singlebit
branch
from
86bc8dc
to
296f9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.