Add View::extents()
#718
Merged
Add View::extents()
#718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
extents
branch
from
b7a346f
to
ae90102
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #718 +/- ##
========================================
Coverage 98.78% 98.78%
========================================
Files 74 74
Lines 7157 7158 +1
========================================
+ Hits 7070 7071 +1
Misses 87 87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's quite common to query the extents of a view, here is a shortcut so you don't need to write
view.mapping().extents(). This also opens the door for slicesSubViewto have different sizes (not in this PR).