Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine LHCb analysis example #741

Merged
merged 10 commits into from
Jun 14, 2023

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Jun 5, 2023

  • Improve terminal output
  • Switch to C++20 (following ROOT's C++20 support)
  • Show how to download the input file
  • Add missing columns and preserve file order
  • Avoid "_copy" in dumped ROOT histograms
  • Add another mapping grouping H1ProbK with the ..isMuons
  • Refactor file writing
  • Allow to customize bits for layout 6 and 8
  • Dump smaller layout visualization
  • Including a few missing bitpack runs

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #741 (be35122) into develop (77fb27d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head be35122 differs from pull request most recent head 4b2f936. Consider uploading reports for the commit 4b2f936 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #741   +/-   ##
========================================
  Coverage    98.80%   98.80%           
========================================
  Files           75       75           
  Lines         7212     7212           
========================================
  Hits          7126     7126           
  Misses          86       86           

@bernhardmgruber bernhardmgruber force-pushed the lhcb_all branch 4 times, most recently from be35122 to 0d9a8f4 Compare June 8, 2023 08:22
@bernhardmgruber bernhardmgruber marked this pull request as ready for review June 14, 2023 11:53
@bernhardmgruber bernhardmgruber merged commit f927b65 into alpaka-group:develop Jun 14, 2023
@bernhardmgruber bernhardmgruber deleted the lhcb_all branch June 14, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant