Improve concept definitions #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The concept formatting looks way nicer with clang-format-16. I think we should update before merging this PR. Edit: done in #752 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #751 +/- ##
========================================
Coverage 98.80% 98.80%
========================================
Files 75 75
Lines 7212 7212
========================================
Hits 7126 7126
Misses 86 86 |
bernhardmgruber
force-pushed
the
format_concepts
branch
5 times, most recently
from
e7461fc
to
51665ea
Compare
bernhardmgruber
force-pushed
the
format_concepts
branch
from
51665ea
to
2c2987d
Compare
bernhardmgruber
force-pushed
the
format_concepts
branch
from
2c2987d
to
04fc187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats and improves some of the concept definitions in LLAMA.