Refactor constructField #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
ref_construct
branch
from
d600b1a
to
cb2b150
Compare
bernhardmgruber
force-pushed
the
ref_construct
branch
from
cb2b150
to
f11d7df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #761 +/- ##
========================================
Coverage 98.73% 98.73%
========================================
Files 70 70
Lines 6896 6898 +2
========================================
+ Hits 6809 6811 +2
Misses 87 87 |
bernhardmgruber
force-pushed
the
ref_construct
branch
from
7263c2d
to
11a3b00
Compare
The legacy lambda processor has problems parsing some lambda functions in LLAMA, like polymorphic lambdas with attributes, e.g. used in constructField.
bernhardmgruber
force-pushed
the
ref_construct
branch
from
11a3b00
to
6e6c41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of
constructField. An issue with MSVC was uncovered during this refactoring, and solved by enabling the newer lambda processor in MSVC, which is used by default in C++20.