Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

PP-9940: Update the dockerfile, Makefile, and add tests and workflows #2

Merged
merged 1 commit into from
Aug 22, 2022
Merged

PP-9940: Update the dockerfile, Makefile, and add tests and workflows #2

merged 1 commit into from
Aug 22, 2022

Conversation

jfharden
Copy link

Add:

  1. test and post-merge workflows
  2. govuk tests for the built container

Update:

  1. Dockerfile to specify alpine version
  2. Makefile to get the actual version of carbon-relay-ng irrespective of our alpha_release-X tagging

@jfharden jfharden force-pushed the pp-9940-update-dockerfile-and-test branch 5 times, most recently from 044b3b8 to 3f0cdda Compare August 22, 2022 10:39
@jfharden jfharden force-pushed the pp-9940-update-dockerfile-and-test branch from 3f0cdda to 38b01a7 Compare August 22, 2022 10:51
@jfharden jfharden marked this pull request as ready for review August 22, 2022 10:53
katstevens
katstevens reviewed Aug 22, 2022
View reviewed changes
.github/workflows/run-tests.yml
run: |
set -euo pipefail

go get github.com/shuLhan/go-bindata/cmd/go-bindata
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the Go ecosystem - is this repo commonly used for builds?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can honestly say I have no idea :) It is however how carbon-relay-ng has to be built (from their own instructions)

katstevens
katstevens approved these changes Aug 22, 2022
View reviewed changes
Copy link

@katstevens katstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - one small non-blocking question

@jfharden jfharden merged commit ceacbd3 into master Aug 22, 2022
@jfharden jfharden deleted the pp-9940-update-dockerfile-and-test branch August 22, 2022 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katstevens katstevens katstevens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfharden @katstevens