Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last dependency on
govuk_frontend_toolkit
, for button styles. Most of the buttons in finder-frontend had already been converted to use the button component already.This change involves a visual change on the subscription page. This button is now using the button component:
Before
After
This change unfortunately required a custom wrapper on the text above in order to provide margin bottom. Hopefully this will be made obsolete at some point if the govspeak component is given margin bottom.
Note: in replacing this button I noticed that the
submit_tag
rails command adds a data attribute ofdata-disable-with
to the outputted HTML. I don't know if this is important but to be safe I've configured the button component to include this attribute.Example links:
I don't think there's any other buttons, but happy to be proved wrong.