Apply margin bottom to big number component on homepage #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pull request closed in error #3117
What
Apply a
margin_bottomattribute to the instances of the big number component on the gov.uk homepage and remove the wrapper that was there previously and it's associated styling.Why
Now that big numbers have the option to apply a custom margin bottom, it makes sense to use it instead of applying wrappers.
Card
Visual changes (mobile only)
This change suffers from the same issue a number of elements on the homepage are suffering from in that they are forced to use the design system spacing matrix and we can't control spacing between screen sizes. More details on this issue alphagov/govuk-frontend#2457. In that respect, this change potentially introduces a visual regression.
Before
After