Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rest-client 2.1, the gzip behaviour has changed rest-client/rest-client#597 such that it relies on Net::HTTP rather than performing the decompression itself.
This test is currently failing because the body is not getting decoded correctly, and I can't find a way of getting it to pass. It's blocking us from adding new features so I thought it would be reasonable to temporarily comment it out and I'll write up a card for Platform Health to investigate putting it back.
Error
I'm not sure if the test is actually useful in the first place because we're testing HTTP behaviour of the Gem, not anything in our code.
I've tried the following things to get it to work:
Accept-Encoding
header (although it seems like this definitely shouldn't work: GZip content not automatically being deflated jnunemaker/httparty#562 (comment))Content-Type
header.GzipWriter
.One thing I've noticed is that for some reason
decode_content
is always set to false on the Net::HTTPResponse object (https://ruby-doc.org/stdlib-2.6.3/libdoc/net/http/rdoc/Net/HTTPResponse.html).