Skip to content

Commit

Permalink
Remove redundant wrapper div
Browse files Browse the repository at this point in the history
This is only used in tests, for which we can use the `app-phase-banner` class instead.
  • Loading branch information
36degrees committed Nov 19, 2021
1 parent a5860d4 commit a04885b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion __tests__/accessiblity_audit.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ async function audit (page) {
const axe = new AxePuppeteer(page)
.include('body')
.exclude('#app-site-search__input') // axe reports there is "no label associated with the text field", when there is one.
.exclude('.app-phase-banner__wrapper') // axe reports that the phase banner is not inside a landmark, which is intentional.
.exclude('.app-phase-banner') // axe reports that the phase banner is not inside a landmark, which is intentional.

const results = await axe.analyze()

Expand Down
3 changes: 0 additions & 3 deletions views/partials/_banner.njk
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
{% if bannerText %}
{% from "govuk/components/phase-banner/macro.njk" import govukPhaseBanner %}

<div class="app-phase-banner__wrapper">

{% set bannerClasses = "app-phase-banner app-width-container" %}
{% if masthead %}
{% set bannerClasses = bannerClasses + " app-phase-banner--no-border" %}
Expand All @@ -32,5 +30,4 @@
"classes": bannerClasses,
"html": bannerText
}) }}
</div>
{% endif %}

0 comments on commit a04885b

Please sign in to comment.