-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update image to generic journey on the check a service is suitable pa… #2133
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from a code point of view.
If we wanted to save a few more kb on the svg size, we could run it through something like https://jakearchibald.github.io/svgomg/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few visual details would neaten this up a bit. Sorry @Ciandelle for the pedantry that follows...
Join the blue 'bracket' lines so they have a clean corner (these are more pronounced at higher zooms)
Centre-align the dotted line for the 'not eligible' route with the bottom of the question 1 page
Stop the arrow heads overlapping with the dotted line underneath, maybe by shortening the lines or joining them to the arrow head
…tern page and compress it to save space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Ciandelle !
update image to generic journey on the check a service is suitable pattern page