Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image to generic journey on the check a service is suitable pa… #2133

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

Ciandelle
Copy link
Contributor

update image to generic journey on the check a service is suitable pattern page

@Ciandelle Ciandelle added Enhancement: feature-request User requests a new feature design check service is suitable Help users to check a service is suitable labels Apr 12, 2022
@Ciandelle Ciandelle self-assigned this Apr 12, 2022
@netlify
Copy link

netlify bot commented Apr 12, 2022

You can preview this change here:

Name Link
🔨 Latest commit 9b20828
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/6257f2b81676a7000980fb52
😎 Deploy Preview https://deploy-preview-2133--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a code point of view.

If we wanted to save a few more kb on the svg size, we could run it through something like https://jakearchibald.github.io/svgomg/

Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few visual details would neaten this up a bit. Sorry @Ciandelle for the pedantry that follows...


Join the blue 'bracket' lines so they have a clean corner (these are more pronounced at higher zooms)
Screenshot 2022-04-13 at 09 30 51


Centre-align the dotted line for the 'not eligible' route with the bottom of the question 1 page
Screenshot 2022-04-13 at 09 31 01


Stop the arrow heads overlapping with the dotted line underneath, maybe by shortening the lines or joining them to the arrow head
Screenshot 2022-04-13 at 09 30 57

Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Ciandelle !

@Ciandelle Ciandelle merged commit 9a9e4dd into main Apr 14, 2022
@Ciandelle Ciandelle deleted the check-a-service-is-suitable-pattern branch April 14, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check service is suitable Help users to check a service is suitable design Enhancement: feature-request User requests a new feature
Projects
Development

Successfully merging this pull request may close these issues.

3 participants