Preview v5: Skip initialisation when GOV.UK Frontend is not supported #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
changed the title
colinrotherham
force-pushed
the
v5-supported-check
branch
from
c9ae343
to
7b4a711
Compare
domoscargin
approved these changes
Aug 1, 2023
| @@ -3,7 +3,7 @@ class BackToTop { | |||
| * @param {Element} $module - HTML element | |||
| */ | |||
| constructor ($module) { | |||
| if (!($module instanceof HTMLElement)) { | |||
| if (!($module instanceof HTMLElement) || !document.body.classList.contains('govuk-frontend-supported')) { | |||
There was a problem hiding this comment.
All these identical constructor-y bits just make me want to do a base component sooner!
colinrotherham
force-pushed
the
v5-types
branch
3 times, most recently
from
67e5a4e
to
399f2fb
Compare
colinrotherham
force-pushed
the
v5-supported-check
branch
from
7b4a711
to
08d8b3c
Compare
colinrotherham
force-pushed
the
v5-types
branch
from
399f2fb
to
25c911c
Compare
This closes the support gap for browsers without ES module support still loading JavaScript-only styles
See approach on GOV.UK Frontend alphagov/govuk-frontend@7e1d0f4
colinrotherham
force-pushed
the
v5-supported-check
branch
from
08d8b3c
to
f5f35e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
.js-enabledto.govuk-frontend-supportedas we did for:.govuk-frontend-supportedfor ES modules support govuk-frontend#3801Added separately to #2958 as lots of functionality is broken until we preview v5