Link to MDN instead of w3schools on links page #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
querkmachine
approved these changes
Apr 2, 2024
|
That's the wrong link. It should go to the documentation about the 'hreflang' attribute for anchor not for the link elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Where we reference
hreflangwhen talking about links to pages in other languages, use MDN as a source instead of w3schools.Why
Prompted by alphagov/govuk-design-system-backlog#64 (comment)
In my opinion, w3schools isn't an untrustworthy resource but MDN is typically more reliable, a little less digestible than w3s but still better than directly linking to specs and more common across our guidance when referencing browser tech.