Use button element for entire input replacement #13075
patrickpatrickpatricktests.yml
on: pull_request
Matrix: Install
Matrix: Build
Diff changes to npm package
/
Generate diff
1m 10s
Stats comment
/
Generate stats
37s
Matrix: lint
Percy
/
Send screenshots
1m 27s
Matrix: Bundler integrations / Test tree shaking
Matrix: package
Matrix: test
Matrix: verify
Annotations
8 errors
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › choose file button › renders the button with default text:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L100
expect(received).toBe(expected) // Object.is equality
Expected: "Choose file"
Received: "<span class=\"govuk-button govuk-button--secondary govuk-file-upload__pseudo-button\">Choose file</span><span class=\"govuk-visually-hidden\">, </span><span class=\"govuk-body govuk-file-upload__status\">No file chosen</span>"
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:100:39)
|
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › status element › renders the status element with role:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L116
expect(received).toBe(expected) // Object.is equality
Expected: "status"
Received: null
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:116:39)
|
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › i18n › uses the correct translation for the choose file button:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L259
expect(received).toBe(expected) // Object.is equality
Expected: "Dewiswch ffeil"
Received: "<span class=\"govuk-button govuk-button--secondary govuk-file-upload__pseudo-button\">Dewiswch ffeil</span><span class=\"govuk-visually-hidden\">, </span><span class=\"govuk-body govuk-file-upload__status\">Dim ffeiliau wedi'u dewis</span>"
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:259:30)
|
|
JavaScript component tests (ubuntu-22.04)
Process completed with exit code 1.
|
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › choose file button › renders the button with default text:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L100
expect(received).toBe(expected) // Object.is equality
Expected: "Choose file"
Received: "<span class=\"govuk-button govuk-button--secondary govuk-file-upload__pseudo-button\">Choose file</span><span class=\"govuk-visually-hidden\">, </span><span class=\"govuk-body govuk-file-upload__status\">No file chosen</span>"
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:100:39)
|
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › status element › renders the status element with role:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L116
expect(received).toBe(expected) // Object.is equality
Expected: "status"
Received: null
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:116:39)
|
|
/components/file-upload › /components/file-upload/preview › when JavaScript is available › i18n › uses the correct translation for the choose file button:
packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L259
expect(received).toBe(expected) // Object.is equality
Expected: "Dewiswch ffeil"
Received: "<span class=\"govuk-button govuk-button--secondary govuk-file-upload__pseudo-button\">Dewiswch ffeil</span><span class=\"govuk-visually-hidden\">, </span><span class=\"govuk-body govuk-file-upload__status\">Dim ffeiliau wedi'u dewis</span>"
at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:259:30)
|
|
JavaScript component tests (windows-latest)
Process completed with exit code 1.
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
JavaScript behaviour tests coverage (ubuntu-22.04)
|
236 KB |
|
|
JavaScript behaviour tests coverage (windows-latest)
|
236 KB |
|
|
JavaScript unit tests coverage (ubuntu-22.04)
|
215 KB |
|
|
JavaScript unit tests coverage (windows-latest)
|
215 KB |
|
|
Package diff
|
3.38 KB |
|