Skip to content

Commit

Permalink
Remove heading class in table docs
Browse files Browse the repository at this point in the history
This isn't necessary as we already have heading style modifiers for table captions. This does mean it's inconsistent with our docs that say they should correspond with heading typography classes. Suggest we should solve this holistically down the line.
  • Loading branch information
owenatgov committed Sep 29, 2023
1 parent 10beebe commit 32a6181
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ examples:
- name: table with head and caption
options:
caption: 'Caption 1: Months and rates'
captionClasses: govuk-heading-m
captionClasses: govuk-table__caption--m
firstCellIsHeader: true
head:
- text: Month you apply
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Table', () => {
const $ = render('table', examples['table with head and caption'])
const $caption = $('.govuk-table__caption')

expect($caption.hasClass('govuk-heading-m')).toBeTruthy()
expect($caption.hasClass('govuk-table__caption--m')).toBeTruthy()
})
})

Expand Down

0 comments on commit 32a6181

Please sign in to comment.