Should the iff function be public or namespaced?

[NickColley]

Something I noticed when doing the work to show the sass docs is that the iff function is the odd one out. It is public but does not have govuk- namespace.
Proposals

1. make it private by changing it's name to _iff and updating sass docs
2. make it consistent by changing it's name to govuk-iff

My preference would be to make it private since it's not a GOV.UK Frontend specific thing and is really an internal function.

• Source code

[36degrees]

We could also consider removing if and just using Sass' built-in if function – I don't think it'd make sense to rename it to govuk-iff as we lose all the benefits of conciseness over if.

Have we seen any evidence of this causing issues for users?

[NickColley]

Have we seen any evidence of this causing issues for users?

No evidence other than when generating the Sass docs it creates an inconsistency and we'd then be promoting something that feels like we made a mistake on.

I also think there's likely not much use of this function yet so would prefer sort it out before having it document, or as my preference would be to make it private.

We could make it private without changing the name of course.

We could also consider removing if and just using Sass' built-in if function

Would be up for avoiding it entirely if that's an option.

[36degrees]

For context, this was added as 'syntactic sugar' for situations like this:

@mixin govuk-typography-weight-regular($important: false) {
  font-weight: $govuk-font-weight-regular iff($important, !important);
}

Sass' default if function always requires you to pass an else clause:

.foo {
  font-weight: $govuk-font-weight-regular if($important, !important, ""); 
}

[36degrees]

Closing in favour of #1771 as we've made a decision and I believe the original issue has been resolved.