Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template from the core layer to the objects layer #1799

Closed
2 tasks done
Tracked by #2274
36degrees opened this issue May 5, 2020 · 0 comments · Fixed by #2463
Closed
2 tasks done
Tracked by #2274

Move template from the core layer to the objects layer #1799

36degrees opened this issue May 5, 2020 · 0 comments · Fixed by #2463

Comments

@36degrees
Copy link
Contributor

36degrees commented May 5, 2020

What

Move the template styles from core/_template.scss to objects/_template.scss, so that we treat it as an object rather than core styling.

Why

As proposed in alphagov/govuk-design-system-architecture#22, we’re making changes to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, to reduce the time it takes to compile to CSS.

We think that template is the only thing currently in the core layer that you might want to import using a single entry point, e.g. in contexts such as React. Rather than giving it 'special treatment', we can move it to the objects layer and then apply consistent approaches within each layer.

Done when

  • TBC
  • "Details of breaking change" section below completed to help with writing release notes

Details of breaking change

  • which users are affected: TBC
  • the change that’s been made: TBC
  • changes users will have to make: TBC
  • impact of users not making those changes: TBC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants