Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template styles from core to objects layer #2463

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

vanitabarrett
Copy link
Contributor

Closes #1799

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2463 December 7, 2021 09:55 Inactive
@vanitabarrett vanitabarrett changed the title Move template styles from core to objects layer Move template styles from core to objects layer Dec 7, 2021
@vanitabarrett vanitabarrett force-pushed the move-template-to-objects-layer branch from 264e8cd to e23299f Compare December 7, 2021 12:14
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2463 December 7, 2021 12:15 Inactive
@vanitabarrett vanitabarrett force-pushed the move-template-to-objects-layer branch from e23299f to d987df2 Compare December 7, 2021 12:15
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2463 December 7, 2021 12:15 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review December 7, 2021 12:19
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Suggesting one small change, then good to merge methinks.

@vanitabarrett vanitabarrett force-pushed the move-template-to-objects-layer branch from d987df2 to 13b40ce Compare December 7, 2021 15:50
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2463 December 7, 2021 15:50 Inactive
@vanitabarrett vanitabarrett merged commit 4f81ad9 into main Dec 7, 2021
@vanitabarrett vanitabarrett deleted the move-template-to-objects-layer branch December 7, 2021 15:54
@vanitabarrett vanitabarrett mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move template from the core layer to the objects layer
4 participants