Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated $govuk-border-width-form-element-error variable #1871

Closed
1 task done
Tracked by #2274
36degrees opened this issue Jul 17, 2020 · 1 comment · Fixed by #1963
Closed
1 task done
Tracked by #2274

Remove deprecated $govuk-border-width-form-element-error variable #1871

36degrees opened this issue Jul 17, 2020 · 1 comment · Fixed by #1963
Assignees
Milestone

Comments

@36degrees
Copy link
Contributor

36degrees commented Jul 17, 2020

What

Remove the $govuk-border-width-form-element-error setting, and update any references in the code to use $govuk-border-width-form-element, or to just set the border-color as appropriate.

Why

We deprecated $govuk-border-width-form-element-error in #1870 the border width of form elements in their error state ($govuk-border-width-form-element-error) is now the same as form elements in their normal state ($govuk-border-width-form-element) – both are 2px.

This isn't something we think users need to be able to configure, and we don't really want the complexity of trying to support different border widths for the error state (for example, the box shadow override that we removed in 06623f8 would need to be conditionally added if the user changed $govuk-border-width-form-element in order to maintain a consistent focus state).

Who needs to know about this

Developers, Tech Writer

Done when

  • $govuk-border-width-form-element-error has been removed
@36degrees 36degrees added this to the v4.0.0 milestone Jul 17, 2020
@vanitabarrett vanitabarrett self-assigned this Sep 18, 2020
@EoinShaughnessy EoinShaughnessy changed the title Remove deprecated $govuk-border-width-form-element-error setting Remove deprecated $govuk-border-width-form-element-error setting Sep 7, 2021
@EoinShaughnessy
Copy link
Contributor

@vanitabarrett @36degrees Do we need to update the title and description to say 'variable' instead of 'setting'? (Asking in case any users ever end up on this PR.)

@vanitabarrett vanitabarrett changed the title Remove deprecated $govuk-border-width-form-element-error setting Remove deprecated $govuk-border-width-form-element-error variable Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants