Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated $govuk-border-width-form-element-error variable #1963

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Sep 18, 2020

Fixes #1871

This change is related to #1870

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1963 September 18, 2020 13:26 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@36degrees
Copy link
Contributor

Minor wording thing: We already deprecated $govuk-border-width-form-element-error in #1870, so this PR is now removing the thing which was previously deprecated ('marked for removal').

I think this mostly affects the release note, but it'd be good to update the PR title. I don't think it's enough of an issue to worry about the branch name?

@vanitabarrett vanitabarrett changed the title Deprecate border width error Remove deprecated $govuk-border-width-form-element-error Sep 23, 2020
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1963 September 23, 2020 10:56 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-fronte-deprecate--yiwqlg November 30, 2020 13:42 Inactive
@vanitabarrett vanitabarrett added this to the v4.0.0 milestone Dec 3, 2020
@vanitabarrett vanitabarrett removed this from the v4.0.0 milestone Aug 18, 2021
@EoinShaughnessy EoinShaughnessy changed the title Remove deprecated $govuk-border-width-form-element-error Remove deprecated $govuk-border-width-form-element-error Sep 14, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-1963 October 5, 2021 12:46 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-1963 October 5, 2021 12:49 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review October 5, 2021 12:59
@vanitabarrett vanitabarrett merged commit b2016f7 into main Oct 5, 2021
@vanitabarrett vanitabarrett deleted the deprecate-border-width-error branch October 5, 2021 13:01
@vanitabarrett vanitabarrett changed the title Remove deprecated $govuk-border-width-form-element-error Remove deprecated $govuk-border-width-form-element-error variable Oct 14, 2021
36degrees added a commit that referenced this pull request Oct 27, 2021
Also tweak the note for #2370 and #1963 so that we're talk about the removal of deprecated features consistently.
36degrees added a commit that referenced this pull request Oct 27, 2021
Also tweak the note for #2370 and #1963 so that we're talk about the removal of deprecated features consistently.

Co-authored-by: Eoin Shaughnessy <eoin.shaughnessy@digital.cabinet-office.gov.uk>
@vanitabarrett vanitabarrett mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated $govuk-border-width-form-element-error variable
4 participants