Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GOV.UK Frontend build pipeline to use Dart Sass #2239

Closed
1 task done
36degrees opened this issue Jun 1, 2021 · 1 comment · Fixed by #3164, #3191 or #3193
Closed
1 task done

Migrate GOV.UK Frontend build pipeline to use Dart Sass #2239

36degrees opened this issue Jun 1, 2021 · 1 comment · Fixed by #3164, #3191 or #3193

Comments

@36degrees
Copy link
Contributor

36degrees commented Jun 1, 2021

What

Migrate GOV.UK Frontend's tooling to use Dart Sass rather than LibSass.

This does not include migrating to the module system or dropping support for LibSass or Ruby Sass – we'll continue to test against and support all three compilers for the time being.

This only affects which compiler we use internally to generate the stylesheets used in the review app, and when compiling minified stylesheets for 'dist'.

Why

Dart Sass is the only one of the three compilers we support that is not deprecated. Increasingly, new projects should and likely will be using Dart Sass.

Changes are being made to Dart Sass including deprecations (like #2238) which may cause warnings and other issues for our users. Using Dart Sass as our primary compiler will help us to identify these issues earlier.

Who needs to know about this

Developers

Done when

  • GOV.UK Frontend build pipeline updated to use Dart Sass rather than LibSass
@querkmachine
Copy link
Member

We may want to re-evaluate priority on this as we're starting to run into compatibility issues running node-sass with Node 16 on Apple Silicon Macs (#2574).

node-sass has apparently been updated to work on Node 16, though some commenters seem to dispute the efficacy of those fixes (sass/node-sass#3077, sass/node-sass#3090). It does not have any support for arm64 architecture as of writing (open issue sass/node-sass#3033), and this is likely not a priority given the package has been deprecated.

@36degrees 36degrees moved this to Needs review 🔍 in GOV.UK Design System cycle board Feb 2, 2023
@colinrotherham colinrotherham reopened this Feb 7, 2023
@colinrotherham colinrotherham linked a pull request Feb 7, 2023 that will close this issue
@stevenjmesser stevenjmesser moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board Feb 8, 2023
@colinrotherham colinrotherham reopened this Feb 8, 2023
@colinrotherham colinrotherham moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Feb 14, 2023
@domoscargin domoscargin moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Mar 2, 2023
@colinrotherham colinrotherham removed their assignment Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment