-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node to Active LTS version v16 (Gallium) #2574
Conversation
|
0cbef39
to
551b238
Compare
I got this working locally on an M1 machine by running:
It might be worth deleting the |
I have a new M1 mac so tried switching to this branch immediately after cloning the repo, installing and using 16.14.0 without having installed or run GOV.UK Frontend under v14, and was able to install and start without any issues. So wondering if this is 'only' an issue for users migrating from 14 to 16. |
@36degrees If that's the case, it sounds like documenting the steps you need to take when going from 14-16 would be enough? |
@vanitabarrett Yes, I think so. |
I've done some more testing to confirm that switching from 14 to 16 is the issue. In that case, I can add some troubleshooting documentation here: https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/running-locally.md
Though this does seem like a pretty temporary problem that affects a small group, so we'd probably want to review it down the line. @EoinShaughnessy Do you have any thoughts? |
@domoscargin Hi! Yeah, I think adding this content is probably a good idea - should help some users, even if only a few. Do we have an idea of when this issue will no longer affect users? Also, what sort of problems might they encounter? Would giving an example help users confirm the issue is to do with using Node v14 or earlier? |
This would stop affecting users once everybody who's installed Once this change is in place, anybody who installs locally for the first time should have no problems. Additionally, if we migrate our build process to Dart Sass (#2239), this problem should go away for anybody who installs after that change. So it's probably a small(ish) pool of users, but with a potentially long tail depending on when they update. The problem is specifically with the |
@domoscargin Great explanation, thanks! Content looks really good! Just suggesting a few tweaks*:
*These might be based on my misunderstanding stuff - if so, sorry! |
910cc18
to
9467817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1️⃣ 6️⃣ 🎉
Node.js v14 has been in maintenance mode from 19 October 2021. v16 is the active LTS version. This in turns updates NPM to v8, meaning our lockfile has change to [`lockfileVersion` 2](https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json#lockfileversion) This is an internal change that affects development, testing and deployment.
If a user has installed govuk-frontend locally on an M1 machine using Node 14 or lower, `node-sass` will cause errors when running `npm install` or `npm start`. This can be solved by following the steps in this commit. This will only affect devs or contributors on Apple silicon who are updating from an older install.
9467817
to
56dbbf0
Compare
Node.js v14 has been in maintenance mode from 19 October 2021. v16 is the active LTS version.
This in turns updates NPM to v8, meaning our lockfile has changed to
lockfileVersion
2This is an internal change that affects development, testing and deployment.
Closes #2504