Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor standard compile tasks to remove Gulp #2712

Closed
6 of 7 tasks
domoscargin opened this issue Jul 20, 2022 · 1 comment
Closed
6 of 7 tasks

Refactor standard compile tasks to remove Gulp #2712

domoscargin opened this issue Jul 20, 2022 · 1 comment
Labels

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jul 20, 2022

What

Update tasks/gulp/compile-assets.js to replace the non-IE8 compile Gulp tasks with our own compile scripts. Updating the IE8 tasks depends on us removing that browser support, so has been separated into its own issue (#2713).

Currently, the scss:compile and js:compile tasks are building both app and dist files, depending on a flag. The pipelines for these files are similar, but not identical, and completely different files are built depending on the flag. We should split this work out and simplify this pipeline.

Why

We have made the decision to move away from Gulp and write our own build scripts.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • IE8 tasks have been separated and run as is
  • App and dist compilations have been split into separate tasks
  • Non-IE8 compilation tasks no longer depend on Gulp
  • Non-IE8 compilation tasks no longer depend on taskArguments.destination
  • docs/contributing/tasks.md has been updated
  • Dependencies are as up to date as is feasible (oldie is a blocker on a lot of these)
  • The tasks have been moved from tasks/gulp to tasks
@domoscargin domoscargin added awaiting triage Needs triaging by team 🕔 days tooling and removed awaiting triage Needs triaging by team labels Jul 20, 2022
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
@kellylee-gds kellylee-gds removed this from the Remove or improve Gulp milestone Feb 2, 2023
@domoscargin
Copy link
Contributor Author

I'm going to close this in favour of #2717 and I'll add some notes there about taskArguments.destination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants