Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE8 Gulp compile tasks #2713

Closed
4 tasks
domoscargin opened this issue Jul 20, 2022 · 1 comment
Closed
4 tasks

Remove IE8 Gulp compile tasks #2713

domoscargin opened this issue Jul 20, 2022 · 1 comment
Labels

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jul 20, 2022

What

Update tasks/gulp/compile-assets.js to remove the IE8-specific compilation tasks. There will likely be side-effects (for example: the update-assets-version task will fail because IE8 files are not compiled).

Why

We have made the decision to move away from Gulp and write our own build scripts. Additionally, we will be dropping support for IE8. A good deal of dependency management is reliant on us removing oldie: #2469

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • IE8 tasks in tasks/gulp/compile-assets.js have been removed
  • Tasks no longer depend on taskArguments.destination
  • docs/contributing/tasks.md has been updated
  • Dependencies have been updated or removed
@domoscargin domoscargin added awaiting triage Needs triaging by team 🕔 days tooling and removed awaiting triage Needs triaging by team labels Jul 20, 2022
@domoscargin domoscargin changed the title Remove IE8 compile tasks Remove IE8 Gulp compile tasks Jul 20, 2022
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
@kellylee-gds kellylee-gds removed this from the Remove or improve Gulp milestone Feb 2, 2023
@domoscargin
Copy link
Contributor Author

I'm going to close this as we've dealt with the gulp aspect of these IE8 compile tasks: #2469

The actual removal of the IE8 compile tasks can be part of the work to remove IE8 in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants