Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate remaining all.scss in favour of index.scss #4988

Closed
2 of 3 tasks
Tracked by #3574
romaricpascal opened this issue May 17, 2024 · 0 comments · Fixed by alphagov/govuk-frontend-docs#490
Closed
2 of 3 tasks
Tracked by #3574

Comments

@romaricpascal
Copy link
Member

romaricpascal commented May 17, 2024

What

Add a deprecation warning in govuk/all.scss file to let people know that we'd prefer them to use govuk/index.scss instead, similarly to what's been done for the all.scss for the different layers of our CSS.

This should be the last all.scss file without deprecation remaining, but worth having a look that:

  • all all.scss files have a corresponding index.scss file
  • all @import in govuk-frontend use the index.scss file and not all.scss (still explicitely using a trailing /index to keep compatibility with older versions of Sass we still support)

Update the exports and sass entries in our package.json so that projects that the update is transparent for people using the npm package.

Update the Frontend docs for any reference to the govuk/all.scss file, replacing it with govuk/index.scss

Why

This is a step in our migration to using index.scss files, with the benefits listed in the first PR for that change.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • A deprecation message is added to the govuk/all.scss
  • The package.json file has been updated
  • The Frontend docs have been updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked ⛔
Development

Successfully merging a pull request may close this issue.

3 participants