Tell users to use index instead of all when referring to sass imports
#490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
romaricpascal
approved these changes
Nov 28, 2024
| ``` | ||
|
|
||
| You do not need `/index` at the end of your import if you’re using Dart Sass, LibSass 3.6.0 or higher, or Ruby Sass 3.6.0 or higher. |
There was a problem hiding this comment.
🙌🏻 Makes sense to be consistent with the rest of the site about this. I'll create an issue to remove statements about LibSass 3.6.0 and Ruby Sass 3.6.0 cross site.
There was a problem hiding this comment.
I wasn't sure about this one. We want to encourage folks to not use deprecated packages but also give folks the correct info if they are and aren't in a position to move off them. I feel like these docs lean more towards the latter.
…orts Update source/installing-with-npm/index.html.md.erb Co-Authored-By: Romaric Pascal <romaric.pascal@digital.cabinet-office.gov.uk>
owenatgov
force-pushed
the
use-index-instead-of-all-for-sass-imports
branch
from
f3e25d6
to
d99f44f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin.
A companion PR to alphagov/govuk-frontend#5518. Once we merge both of these we can close alphagov/govuk-frontend#4988
Notes
There are numerous references to
allin the v4 portion of our docs. We shouldn't update these since v4 doesn't replaceallwithindex.